-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creating Culture and LocalizationSet #15714
Fix creating Culture and LocalizationSet #15714
Conversation
…eated via Graph API.
@MikeAlhayek I'm waiting to reply for my comment here then we can decide if it's the right fix |
Any news with the review here, @hishamco? |
I was waiting for clean steps to reproduce the issue, but here the author shows a sample method, so I can't reproduce the bug |
@all-contributors please add @M-Lipin |
I couldn't determine any contributions to add, did you specify any contributions? |
@Piedone why it doesn't add it as a contributor, or it should be done after the merge |
M-Lipin is already listed as a contributor: https://docs.orchardcore.net/en/latest/community/contributors/ But otherwise it's something like |
I just noticed him for the first time, thanks Do you have anything else to add to this PR or shall I merge |
I wouldn't review if you're OK with it unless you insist on having a second opinion. |
Fixes #15713